GitHub user saturday-shi opened a pull request:
https://github.com/apache/spark/pull/15022
[SPARK-17465] [Spark Core] Inappropriate memory management in
`org.apache.spark.storage.MemoryStore` may lead to memory leak
## What changes were proposed in this pull request?
The expression like `if (memoryMap(taskAttemptId) == 0)
memoryMap.remove(taskAttemptId)` in method `releaseUnrollMemoryForThisTask` and
`releasePendingUnrollMemoryForThisTask` should be called after release memory
operation, whatever `memoryToRelease` is > 0 or not.
If the memory of a task has been set to 0 when calling a
`releaseUnrollMemoryForThisTask` or a `releasePendingUnrollMemoryForThisTask`
method, the key in the memory map corresponding to that task will never be
removed from the hash map.
See the details in
[SPARK-17465](https://issues.apache.org/jira/browse/SPARK-17465).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/saturday-shi/spark SPARK-17465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15022
----
commit 720f2ceb35361f387fc55301fb44b560a289d8ca
Author: Xing SHI <[email protected]>
Date: 2016-09-09T07:58:24Z
Correct the inappropriate memory management operation in
releaseUnrollMemoryForThisTask and releasePendingUnrollMemoryForThisTask method.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
