Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2076#discussion_r16530145
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -73,8 +73,9 @@ class StorageListener(storageStatusListener:
StorageStatusListener) extends Spar
}
override def onStageCompleted(stageCompleted:
SparkListenerStageCompleted) = synchronized {
- // Remove all partitions that are no longer cached
- _rddInfoMap.retain { case (_, info) => info.numCachedPartitions > 0 }
+ // Remove all partitions that are no longer cached in current competed
stage
+ val currentComletedRddInfoIds = Set[Int]() ++
stageCompleted.stageInfo.rddInfos.map(r => r.id)
--- End diff --
There's a typo ("Comleted") and there's no need to make a Set then add to
it. Just call Set(). You say the intent is to only remove infos that are not
cached, but it already seems to do that. This prevents not-completed elements
from being removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
