Github user srinathshankar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15037#discussion_r78260239
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -565,8 +565,9 @@ private[spark] class BlockManager(
                 // Give up trying anymore locations. Either we've tried all of 
the original locations,
                 // or we've refreshed the list of locations from the master, 
and have still
                 // hit failures after trying locations from the refreshed list.
    -            throw new BlockFetchException(s"Failed to fetch block after" +
    -              s" ${totalFailureCount} fetch failures. Most recent failure 
cause:", e)
    +            logError(s"Failed to fetch block after $totalFailureCount 
fetch failures." +
    --- End diff --
    
    If a block is not found at a particular location, I take it that's a 
non-fatal error ? In that case, should we really be logging "error" if the 
block is not found ? Or do we expect the block to be found *somewhere* remotely 
during the normal course of execution ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to