Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15036#discussion_r78260732
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -807,8 +801,8 @@ private[spark] class BlockManager(
// Now that the block is in either the memory or disk store,
// tell the master about it.
info.size = size
- if (tellMaster) {
- reportBlockStatus(blockId, info, putBlockStatus)
+ if (tellMaster && info.tellMaster) {
--- End diff --
Yep, looks like my memory was correct:
Take a look at [ShuffleMapTask in Spark
v0.6.0](https://github.com/apache/spark/blame/v0.6.0/core/src/main/scala/spark/scheduler/ShuffleMapTask.scala#L151):
```
val blockManager = SparkEnv.get.blockManager
for (i <- 0 until numOutputSplits) {
val blockId = "shuffle_" + dep.shuffleId + "_" + partition + "_" + i
// Get a Scala iterator from Java map
val iter: Iterator[(Any, Any)] = bucketIterators(i)
val size = blockManager.put(blockId, iter, StorageLevel.DISK_ONLY,
false)
compressedSizes(i) = MapOutputTracker.compressSize(size)
}
```
Here, `false` is the `tellMaster` parameter.
This functionality in the BlockManager dates back to the original Spark
Streaming engine improvement patch:
https://github.com/apache/spark/commit/63051dd2bcc4bf09d413ff7cf89a37967edc33ba
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
