Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15036#discussion_r78265893
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -807,8 +801,8 @@ private[spark] class BlockManager(
// Now that the block is in either the memory or disk store,
// tell the master about it.
info.size = size
- if (tellMaster) {
- reportBlockStatus(blockId, info, putBlockStatus)
+ if (tellMaster && info.tellMaster) {
--- End diff --
I think that a big clarifying change would be to internally refactor this
so that the `tellMaster` parameter is omitted from all calls and so that the
`tellMaster = false` case for cached and reassembled broadcast blocks is
inferred automatically from the block id. This would clean up a lot of the
function signatures and would make the weird "don't tell the master" exception
much more readily apparent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
