Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/14842#discussion_r78267758 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java --- @@ -27,14 +27,45 @@ public class PrefixComparators { private PrefixComparators() {} - public static final PrefixComparator STRING = new UnsignedPrefixComparator(); - public static final PrefixComparator STRING_DESC = new UnsignedPrefixComparatorDesc(); - public static final PrefixComparator BINARY = new UnsignedPrefixComparator(); - public static final PrefixComparator BINARY_DESC = new UnsignedPrefixComparatorDesc(); - public static final PrefixComparator LONG = new SignedPrefixComparator(); - public static final PrefixComparator LONG_DESC = new SignedPrefixComparatorDesc(); - public static final PrefixComparator DOUBLE = new UnsignedPrefixComparator(); - public static final PrefixComparator DOUBLE_DESC = new UnsignedPrefixComparatorDesc(); --- End diff -- Oh. yeah. I will remove the new lines.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org