Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/15034#discussion_r78269456
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -354,6 +361,39 @@ private[clustering] trait LDAParams extends Params
with HasFeaturesCol with HasM
}
}
+private object LDAParams {
+
+ /**
+ * Equivalent to [[DefaultParamsReader.getAndSetParams()]], but handles
[[LDA]] and [[LDAModel]]
+ * formats saved with Spark 1.6, which differ from the formats in Spark
2.0+.
+ *
+ * @param model [[LDA]] or [[LDAModel]] instance. This instance will
be modified with
+ * [[Param]] values extracted from metadata.
+ * @param metadata Loaded model metadata
+ */
+ def getAndSetParams(model: LDAParams, metadata: Metadata): Unit = {
+ VersionUtils.majorMinorVersion(metadata.sparkVersion) match {
+ case (1, 6) =>
--- End diff --
we didn't support LDA serialization in 1.5, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
