Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269994
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -28,12 +28,31 @@
private PrefixComparators() {}
public static final PrefixComparator STRING = new
UnsignedPrefixComparator();
+ public static final PrefixComparator STRING_NULLLAST = new
UnsignedPrefixComparatorNullLast();
+
+ public static final PrefixComparator STRING_DESC_NULLFIRST =
+ new UnsignedPrefixComparatorDescNullFirst();
public static final PrefixComparator STRING_DESC = new
UnsignedPrefixComparatorDesc();
+
public static final PrefixComparator BINARY = new
UnsignedPrefixComparator();
+ public static final PrefixComparator BINARY_NULLLAST = new
UnsignedPrefixComparatorNullLast();
+
+ public static final PrefixComparator BINARY_DESC_NULLFIRST =
+ new UnsignedPrefixComparatorDescNullFirst();
public static final PrefixComparator BINARY_DESC = new
UnsignedPrefixComparatorDesc();
+
public static final PrefixComparator LONG = new SignedPrefixComparator();
+ public static final PrefixComparator LONG_NULLLAST = new
SignedPrefixComparatorNullLast();
+
+ public static final PrefixComparator LONG_DESC_NULLFIRST =
+ new SignedPrefixComparatorDescNullFirst();
public static final PrefixComparator LONG_DESC = new
SignedPrefixComparatorDesc();
--- End diff --
Probably better to order as LONG, LONG_DESC, LONG_NULL_LAST,
LONG_DESC_NULL_LAST
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
