Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15051#discussion_r78310368
--- Diff: R/pkg/R/mllib.R ---
@@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"),
#' }
#' @note spark.mlp since 2.1.0
setMethod("spark.mlp", signature(data = "SparkDataFrame"),
- function(data, blockSize = 128, layers = c(3, 5, 2), solver =
"l-bfgs", maxIter = 100,
- tol = 0.5, stepSize = 1, seed = 1) {
+ function(data, blockSize = 128, layers, solver = "l-bfgs",
maxIter = 100,
--- End diff --
If the goal is to require layers to have a value (I didn't realize this
from our PR description), then we should have layers as the 2nd parameter
(after data) without any default value.
We should also make sure when layers is later coerced to array that its
values are coerced into integer?
```
> a <- list(1, 2, "a")
> as.integer(a)
[1] 1 2 NA
Warning message:
NAs introduced by coercion
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
