Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2065#discussion_r16549316
  
    --- Diff: 
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumePollingInputDStream.scala
 ---
    @@ -144,6 +168,21 @@ private[streaming] class FlumePollingReceiver(
         }
       }
     
    +  private def sendNack(batchReceived: Boolean, client: 
SparkFlumeProtocol.Callback,
    +    seq: CharSequence): Unit = {
    +    Try {
    +      if (batchReceived) {
    +        // Let Flume know that the events need to be pushed back into the 
channel.
    +        logDebug("Sending nack for sequence number: " + seq)
    +        client.nack(seq) // If the agent is down, even this could fail and 
throw
    +        logDebug("Nack sent for sequence number: " + seq)
    +      }
    +    }.recover({
    +      case e: Exception => logError(
    --- End diff --
    
    nit: move everything to same line, or `logError(` to next line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to