Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15060#discussion_r78409055
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -545,7 +553,9 @@ private[ann] object FeedForwardModel {
* @return model
*/
def apply(topology: FeedForwardTopology, weights: Vector):
FeedForwardModel = {
- // TODO: check that weights size is equal to sum of layers sizes
+ if (weights.size != topology.weightSize) {
+ throw new Exception("Input weight vector has illegal size.")
--- End diff --
Throwing Exception is never great ... use `require` for consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
