Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r78472441 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala --- @@ -262,11 +262,13 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { throw new AnalysisException("Cannot create hive serde table with createExternalTable API.") } + val location = new CaseInsensitiveMap(options).get("path") + val storageProps = options.filterNot { case (k, _) => k.toLowerCase == "path" } --- End diff -- I saw this two line duplicated in at least three places. Maybe we should create a util to extract the path from options?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org