Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14467#discussion_r78515821
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -866,11 +866,14 @@ class BytesToString extends
org.apache.spark.api.java.function.Function[Array[By
}
/**
- * Internal class that acts as an `AccumulatorParam` for Python
accumulators. Inside, it
+ * Internal class that acts as an `AccumulatorV2` for Python accumulators.
Inside, it
* collects a list of pickled strings that we pass to Python through a
socket.
*/
-private class PythonAccumulatorParam(@transient private val serverHost:
String, serverPort: Int)
- extends AccumulatorParam[JList[Array[Byte]]] {
+private[spark] class PythonAccumulatorV2(@transient private val
serverHost: String, serverPort: Int)
+ extends AccumulatorV2[JList[Array[Byte]], JList[Array[Byte]]] {
--- End diff --
Ah, can we use CollectionAccumulator? it's a specialization that's for
accumulating a list of things, so might be good to leverage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
