Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15077#discussion_r78551772
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -795,7 +795,7 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
def makeRDD[T: ClassTag](seq: Seq[(T, Seq[String])]): RDD[T] = withScope
{
assertNotStopped()
val indexToPrefs = seq.zipWithIndex.map(t => (t._2, t._1._2)).toMap
- new ParallelCollectionRDD[T](this, seq.map(_._1), seq.size,
indexToPrefs)
+ new ParallelCollectionRDD[T](this, seq.map(_._1), math.max(seq.size,
defaultParallelism), indexToPrefs)
--- End diff --
The problem is that the default is OK because it's changeable, but here
someone has no way to change it. I think it might be better to stay
conservative.
Really this is such a corner case that it doesn't matter much. It only
showed up for you because you specified no type on your Seq. If you had, it
would have chosen the other overload which works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
