Github user a-roberts commented on a diff in the pull request:
https://github.com/apache/spark/pull/15079#discussion_r78563225
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java
---
@@ -338,15 +338,18 @@ public void appendRowUntilExceedingCapacity() throws
Exception {
@Test
public void appendRowUntilExceedingPageSize() throws Exception {
+ // Use of this property prevents issues when running on a two core
machine
+ // A developer may override this size to 1 MB not 64 MB, so use that
if so
+ int pageSizeToUse =
Integer.parseInt(System.getProperty("spark.buffer.pageSize"));
--- End diff --
Running the tests now with
```
int pageSizeToUse = (int) memoryManager.pageSizeBytes();
```
Looking at the logic in here I see we either use the default page size or
whatever the user specifies
An int is accepted for the allocate method in RowBasedKeyValueBatch, given
that a max int in Java is 2,147m I doubt this will be a problem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
