Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/15082#discussion_r78667613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -276,6 +276,11 @@ class CodegenContext {
case t: DecimalType => s"$row.setDecimal($ordinal, $value,
${t.precision})"
// The UTF8String may came from UnsafeRow, otherwise clone is cheap
(re-use the bytes)
case StringType => s"$row.update($ordinal, $value.clone())"
+ // InternalRow, ArrayData and MapData may came from UnsafeRow, we
should copy it to avoid
+ // keeping a "pointer" to a memory region which is out of control
from the updated row.
+ case _: StructType => s"$row.update($ordinal, $value.copy())"
--- End diff --
If `$row` could do the copy inside `update`, then we do need to do the copy
here, right?
Maybe it's time to check all the MutableRow, MutableProjection, to see
where is the best place to do the copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
