Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14962#discussion_r78687123
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/CatalogSuite.scala ---
    @@ -322,6 +325,14 @@ class CatalogSuite
         assert(e2.message == "Cannot create a file-based external data source 
table without path")
       }
     
    +  test("dropTempView if a same-name table exists") {
    +    withTable("same_name") {
    +      sql("CREATE TABLE same_name(i int) USING json")
    +      spark.catalog.dropTempView("same_name")
    +      
assert(spark.sessionState.catalog.tableExists(TableIdentifier("same_name")))
    +    }
    +  }
    --- End diff --
    
    Let's add comments to explain what this test is for in case we accidentally 
delete it in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to