Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/15090#discussion_r78689452
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -330,14 +332,237 @@ class StatisticsSuite extends QueryTest with
TestHiveSingleton with SQLTestUtils
val dfNoCols = spark.createDataFrame(rddNoCols,
StructType(Seq.empty))
dfNoCols.write.format("json").saveAsTable(table_no_cols)
sql(s"ANALYZE TABLE $table_no_cols COMPUTE STATISTICS")
- checkStats(
+ checkTableStats(
table_no_cols,
isDataSourceTable = true,
hasSizeInBytes = true,
expectedRowCounts = Some(10))
}
}
+ private def checkColStats(
--- End diff --
I used `checkTableStats` in some cases for column stats, so maybe put all
test cases for table/column stats into a separate file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
