Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15074#discussion_r78693515
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -1296,9 +1296,20 @@ def asML(self):
return newlinalg.SparseMatrix(self.numRows, self.numCols,
self.colPtrs, self.rowIndices,
self.values, self.isTransposed)
- # TODO: More efficient implementation:
def __eq__(self, other):
- return np.all(self.toArray() == other.toArray())
+ if self.isTransposed != other.isTransposed:
--- End diff --
I'd say also add an `isinstance(other, SparseMatrix)` check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
