Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14659#discussion_r78768851
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -184,6 +184,9 @@ private[spark] class ApplicationMaster(
         try {
           val appAttemptId = client.getAttemptId()
     
    +      var context = 
s"Spark_AppName_${System.getProperty("spark.app.name")}" +
    --- End diff --
    
    it would be nice to have a class or at least util function to construct the 
context string so that we don't have same string in multiple places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to