Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13493
This looks pretty reasonable to me, the only thing is (and its relatively
minor) testing the default param might be better as a tests.py test rather than
as a doc test since the doctests are part of the documentation and we might not
need this in the docs along with the current example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
