Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/14653
@evanyc15 it looks good in general.
I think the doctests you have here would be better suited as unit tests
because it's not an area normal users would care about and it could reduce code
duplication
It might also be easier for others to review this PR if you picked a single
estimator/model and demonstrated this change once to get feedback before
applying it everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
