Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/14444#discussion_r78900571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -174,59 +174,32 @@ case class CreateMap(children: Seq[Expression])
extends Expression {
/**
* Returns a Row containing the evaluation of all children expressions.
*/
-@ExpressionDescription(
- usage = "_FUNC_(col1, col2, col3, ...) - Creates a struct with the given
field values.")
-case class CreateStruct(children: Seq[Expression]) extends Expression {
-
- override def foldable: Boolean = children.forall(_.foldable)
-
- override lazy val dataType: StructType = {
- val fields = children.zipWithIndex.map { case (child, idx) =>
- child match {
- case ne: NamedExpression =>
- StructField(ne.name, ne.dataType, ne.nullable, ne.metadata)
- case _ =>
- StructField(s"col${idx + 1}", child.dataType, child.nullable,
Metadata.empty)
+object CreateStruct extends (Seq[Expression] => CreateNamedStruct) {
+ def apply(children: Seq[Expression]) : CreateNamedStruct = {
+ val namedStructArgs = {
+ val attNames = for {
+ (child, idx) <- children.zipWithIndex
+ } yield {
+ child match {
+ case ne: NamedExpression => ne.name
+ case _ => s"col${idx + 1}"
--- End diff --
this completely breaks backward compatibility on CreateStruct.
users can now declare a column like this:
'CreateStruct(1 as a, "hello" as b) as struct_field
and later refer to it like so:
'struct_field.a + 1'
your suggestion is guaranteed to break this as 'struct_field' will no
longer have a field named 'a'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
