Github user srowen commented on a diff in the pull request:
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
    @@ -171,14 +166,48 @@ object ChiSqSelectorModel extends 
Loader[ChiSqSelectorModel] {
      * Creates a ChiSquared feature selector.
    - * @param numTopFeatures number of features that selector will select
    - *                       (ordered by statistic value descending)
    - *                       Note that if the number of features is less than 
    - *                       then this will select all features.
    -class ChiSqSelector @Since("1.3.0") (
    -  @Since("1.3.0") val numTopFeatures: Int) extends Serializable {
    +class ChiSqSelector @Since("2.1.0") () extends Serializable {
    +  var numTopFeatures: Int = 50
    +  var percentile: Double = 0.1
    +  var alpha: Double = 0.05
    +  var selectorType = ChiSqSelectorType.KBest
    +  @Since("1.3.0")
    --- End diff --
    The existing constructor should still have javadoc maybe pointing to the 
setNumTopFeatures method to say that's the effect it has

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to