Github user Stibbons commented on the issue:

    https://github.com/apache/spark/pull/14963
  
    Hello, sorry to bother you, but if this patch gets merged, I can work on 
the pylint errors and submit new PR I had to add in the ignore list of pylint.
    
    If I reenable most of them, here is an extract of errors I get:
    ```
    ************* Module pyspark.shell
    W: 78, 8: Use of exec (exec-used)
    ************* Module pyspark.cloudpickle
    R:767,16: Redefinition of v type from property to staticmethod 
(redefined-variable-type)
    ************* Module pyspark.tests
    R:782,12: Redefinition of a type from pyspark.rdd.RDD to 
pyspark.rdd.PipelinedRDD (redefined-variable-type)
    R:783,12: Redefinition of b type from pyspark.rdd.RDD to 
pyspark.rdd.PipelinedRDD (redefined-variable-type)
    ************* Module pyspark.rdd
    R:1467,12: Redefinition of ser type from 
pyspark.serializers.AutoBatchedSerializer to 
pyspark.serializers.BatchedSerializer (redefined-variable-type)
    ************* Module pyspark.context
    R:130,12: Redefinition of self.serializer type from 
pyspark.serializers.AutoBatchedSerializer to 
pyspark.serializers.BatchedSerializer (redefined-variable-type)
    ************* Module pyspark.worker
    W:104,17: Use of eval (eval-used)
    ************* Module pyspark.shuffle
    C:732,32: Consider iterating the dictionary directly instead of calling 
.keys() (consider-iterating-dictionary)
    ************* Module pyspark.ml.tests
    R:1459, 8: Redefinition of a type from pyspark.ml.linalg.DenseVector to 
pyspark.ml.linalg.SparseVector (redefined-variable-type)
    ************* Module pyspark.ml.linalg
    E:683, 4: __len__ does not return non-negative integer 
(invalid-length-returned)
    R:1079, 8: Redefinition of colPtrs type from list to str 
(redefined-variable-type)
    R:1078, 8: Redefinition of rowIndices type from list to str 
(redefined-variable-type)
    ************* Module pyspark.streaming.kafka
    R:132,12: Redefinition of ser type from 
pyspark.serializers.PairDeserializer to 
pyspark.serializers.AutoBatchedSerializer (redefined-variable-type)
    ************* Module pyspark.streaming.tests
    R:419, 8: Redefinition of initial type from list to pyspark.rdd.RDD 
(redefined-variable-type)
    E:506,12: Bad first argument 'StreamingListener' given to super() 
(bad-super-call)
    ************* Module pyspark.streaming.context
    C:298,12: Consider using enumerate instead of iterating with range and len 
(consider-using-enumerate)
    ```
    
    These are not big errors, but it would be quite easy to fix them and have 
pylint runing at each pullrequest.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to