Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15084#discussion_r79138018
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
 ---
    @@ -954,12 +954,12 @@ private class SortMergeFullOuterJoinScanner(
         }
     
         if (leftMatches.size <= leftMatched.capacity) {
    -      leftMatched.clear()
    +      leftMatched.clearUntil(leftMatches.size)
    --- End diff --
    
    I suspect this is a correct change as you describe it, but can you help me 
be 100% sure by describing why we know the bits above this point will be 0 or 
don't matter? I'm trying to think of a case where a leftover set 1 bit from 
previous computation causes a problem. Is that definitely not possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to