Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15093#discussion_r79282245
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -1657,21 +1657,12 @@ class Analyzer(
     
           // Third, for every Window Spec, we add a Window operator and set 
currentChild as the
           // child of it.
    -      var currentChild = child
    -      var i = 0
    -      while (i < groupedWindowExpressions.size) {
    -        val ((partitionSpec, orderSpec), windowExpressions) = 
groupedWindowExpressions(i)
    -        // Set currentChild to the newly created Window operator.
    -        currentChild =
    -          Window(
    -            windowExpressions,
    -            partitionSpec,
    -            orderSpec,
    -            currentChild)
    -
    -        // Move to next Window Spec.
    -        i += 1
    -      }
    +      val currentChild =
    +        groupedWindowExpressions.foldLeft(child) {
    +          case (last, ((partitionSpec, orderSpec), windowExpressions)) =>
    +            // Set currentChild to the newly created Window operator.
    --- End diff --
    
    Sorry, one last thing, can you remove this comment? and update the comment 
above and below this expression? they're no longer applicable. Actually 
`currentChild` isn't a great name now anyway. eh, `windowOps` or something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to