Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2102#discussion_r16629723
  
    --- Diff: docs/building-with-maven.md ---
    @@ -156,4 +156,12 @@ then ship it over to the cluster. We are investigating 
the exact cause for this.
     
     The assembly jar produced by `mvn package` will, by default, include all 
of Spark's dependencies, including Hadoop and some of its ecosystem projects. 
On YARN deployments, this causes multiple versions of these to appear on 
executor classpaths: the version packaged in the Spark assembly and the version 
on each node, included with yarn.application.classpath.  The `hadoop-provided` 
profile builds the assembly without including Hadoop-ecosystem projects, like 
ZooKeeper and Hadoop itself. 
     
    +# Building under http proxy environment
     
    +Sometimes,spark need be built in http proxy environment, We recommend the 
following settings:
    +
    + mvn -Pyarn -Phadoop-2.2 -Dhadoop.version=2.2.0 
-Dmaven.wagon.http.ssl.insecure=true -Dmaven.wagon.http.ssl.allowall=true 
-DskipTests clean package
    --- End diff --
    
    I'm not sure this resolves proxy problems. It may resolve a particular 
issue wherein your network proxy is breaking SSL connections, but is not how 
you configure proxies. See 
http://maven.apache.org/guides/mini/guide-proxies.html 
    
    Attacks are very rare, but if someone were trying to inject a bad binary 
into your build, this would invite users to explicitly ignore that warning 
sign. So I disagree that this is something all users should use when using a 
proxy.
    
    The `yarn` profile and so on are not related, just the two `maven.wagon` 
settings. The error message you quote does not contain the type of failure you 
would see, which is a "could not resolve dependencies" error. Finally, there 
are punctuation and capitalization problems, like "http".
    
    I don't think this should be added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to