Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15024
  
    In 
[DataSource.scala](https://github.com/cloud-fan/spark/blob/9ab4b8ce3dd7c41edb0681ff903d218bad2e4225/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala),
 streaming sources are still built on the `path` key in the parameter 
`options`. I tried to find whether any of non-streaming data sources still 
requires `path`. Unable to find more except the two comments I left above. 
    
    You know, `CreateTempViewUsing` is still directly passing `path` in 
`options` when building a data source. Thus, we might need further PRs to clean 
the related code further, I think. 
    
    Currently, we have two ways to pass the values of `path`. Eventually, the 
file path should be passed through a single parameter, `paths`. 
    
    ```Scala
    case class DataSource(
        sparkSession: SparkSession,
        className: String,
        paths: Seq[String] = Nil,
        userSpecifiedSchema: Option[StructType] = None,
        partitionColumns: Seq[String] = Seq.empty,
        bucketSpec: Option[BucketSpec] = None,
        options: Map[String, String] = Map.empty) extends Logging {
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to