Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15041#discussion_r79410775
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1384,14 +1385,15 @@ abstract class RDD[T: ClassTag](
* @param ord the implicit ordering for T
* @return an array of top elements
*/
- def takeOrdered(num: Int)(implicit ord: Ordering[T]): Array[T] =
withScope {
+ def takeOrdered(num: Int, ser: Serializer = SparkEnv.get.serializer)
--- End diff --
this will break the java API.
BTW, this method returns an Array, I don't think we can avoid OOM for large
`num` anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
