Github user JoshRosen commented on a diff in the pull request:
    --- Diff: 
    @@ -109,7 +109,9 @@ object EliminateOuterJoin extends Rule[LogicalPlan] 
with PredicateHelper {
         if (!e.deterministic || SubqueryExpression.hasCorrelatedSubquery(e)) 
return false
         val attributes = e.references.toSeq
         val emptyRow = new GenericInternalRow(attributes.length)
    -    val v = BindReferences.bindReference(e, attributes).eval(emptyRow)
    +    val boundE = BindReferences.bindReference(e, attributes)
    +    if (boundE.find(_.isInstanceOf[Unevaluable]).isDefined) return false
    --- End diff --
    Also I guess that the `AttributeReferences` should have been replaced 
following binding in the previous line, so this looks good to me.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to