Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15160#discussion_r79669450
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
 ---
    @@ -47,15 +47,11 @@ case class CreateDataSourceTableCommand(table: 
CatalogTable, ignoreIfExists: Boo
         assert(table.provider.isDefined)
     
         val sessionState = sparkSession.sessionState
    -    val db = 
table.identifier.database.getOrElse(sessionState.catalog.getCurrentDatabase)
    -    val tableIdentWithDB = table.identifier.copy(database = Some(db))
    -    // Pass a table identifier with database part, so that `tableExists` 
won't check temp views
    -    // unexpectedly.
    -    if (sessionState.catalog.tableExists(tableIdentWithDB)) {
    +    if (sessionState.catalog.tableExists(table.identifier)) {
           if (ignoreIfExists) {
             return Seq.empty[Row]
           } else {
    -        throw new AnalysisException(s"Table 
${tableIdentWithDB.unquotedString} already exists.")
    +        throw new AnalysisException(s"Table 
${table.identifier.unquotedString} already exists.")
    --- End diff --
    
    The test failure is caused by this change. After this PR, 
`table.identifier` does not always have the database name. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to