Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/15051
  
    could you add a test for passing seed and a test for not passing seed - I'm 
not sure if we have a good way to check for specific result (likely there is 
since we choose the seed value)
    but we should at least make sure passing seed get us a different result as 
not passing seed (default seed value)?
    we have had some problem with that in the past so it'd be better to test 
for them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to