Github user winningsix commented on a diff in the pull request: https://github.com/apache/spark/pull/15172#discussion_r79746570 --- Diff: common/network-common/pom.xml --- @@ -97,6 +97,11 @@ <artifactId>slf4j-log4j12</artifactId> <scope>test</scope> </dependency> + <dependency> --- End diff -- Can we move this dependency to L62 since the dependency around is test only. You can see the comment in L64 and L80
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org