Github user jiangxb1987 commented on the issue:

    https://github.com/apache/spark/pull/14917
  
    @hvanhovell In `CheckAnalysis` we have ensured all aggregateExpressions can 
be derived from groupingExpressions (refer to function 
`checkValidAggregateExpression`), but in optimize stage the rule 
`ReorderAssociativeOperator` broke this. I found the `Aggregate.resolved` is 
only checked in analyze stage so we failed to detect this case. So, maybe 
incorporate this rule into `Aggregate.resolved` brings little help to avoid 
similar problem. Should we check analysis again after we have performed all 
optimize rules? Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to