Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14650
OK I understand more about why the code is structured this way. Let me back
up another step before coming back to the details.
It feels like this change is trying to unify `MesosClusterDispatcher` and
`SparkSubmit`. That doesn't feel like the role of `MesosClusterDispatcher`. It
seems like a peer of things like the `Master` class for standalone.
I wonder why the `YARNAllocator` or `Master` doesn't have a `--conf`
argument ... they seem to receive config via `SparkConf` which in turn would
have been set up by things like `spark-submit`.
That may be why refactoring across these two is hard for me to process here.
Calling in @vanzin if possible for a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
