Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15122#discussion_r79925163
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/FileStreamSourceSuite.scala
 ---
    @@ -73,4 +83,44 @@ class FileStreamSourceSuite extends SparkFunSuite {
         assert(map.isNewFile(FileEntry("b", 10)))
       }
     
    +  testWithUninterruptibleThread("do not recheck that files exist during 
getBatch") {
    +    withTempDir { temp =>
    +      spark.conf.set(
    +        s"fs.$scheme.impl",
    +        classOf[ExistsThrowsExceptionFileSystem].getName)
    +      // add the metadata entries as a pre-req
    +      val dir = new File(temp, "dir") // use non-existent directory to 
test whether log make the dir
    +      val metadataLog = new HDFSMetadataLog[Array[FileEntry]](spark, 
dir.getAbsolutePath)
    --- End diff --
    
    Need to use `FileStreamSourceLog` here to add FileEntry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to