Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15090#discussion_r79965425
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/StatisticsColumnSuite.scala ---
    @@ -0,0 +1,352 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql
    +
    +import java.sql.{Date, Timestamp}
    +
    +import org.apache.spark.sql.catalyst.parser.ParseException
    +import org.apache.spark.sql.catalyst.plans.logical.ColumnStats
    +import org.apache.spark.sql.catalyst.util.DateTimeUtils
    +import org.apache.spark.sql.execution.command.AnalyzeColumnCommand
    +import org.apache.spark.sql.types._
    +
    +class StatisticsColumnSuite extends StatisticsTest {
    +  import testImplicits._
    +
    +  test("parse analyze column commands") {
    +    def assertAnalyzeColumnCommand(analyzeCommand: String, c: Class[_]) {
    +      val parsed = spark.sessionState.sqlParser.parsePlan(analyzeCommand)
    +      val operators = parsed.collect {
    +        case a: AnalyzeColumnCommand => a
    +        case o => o
    +      }
    +      assert(operators.size == 1)
    +      if (operators.head.getClass != c) {
    +        fail(
    +          s"""$analyzeCommand expected command: $c, but got 
${operators.head}
    +             |parsed command:
    +             |$parsed
    +           """.stripMargin)
    +      }
    +    }
    +
    +    val table = "table"
    +    assertAnalyzeColumnCommand(
    +      s"ANALYZE TABLE $table COMPUTE STATISTICS FOR COLUMNS key, value",
    +      classOf[AnalyzeColumnCommand])
    +
    +    intercept[ParseException] {
    +      sql(s"ANALYZE TABLE $table COMPUTE STATISTICS FOR COLUMNS")
    +    }
    +  }
    +
    +  test("check correctness of columns") {
    +    val table = "tbl"
    +    val colName1 = "abc"
    +    val colName2 = "x.yz"
    +    val quotedColName2 = s"`$colName2`"
    +    withTable(table) {
    +      sql(s"CREATE TABLE $table ($colName1 int, $quotedColName2 string) 
USING PARQUET")
    +
    +      val invalidColError = intercept[AnalysisException] {
    +        sql(s"ANALYZE TABLE $table COMPUTE STATISTICS FOR COLUMNS key")
    +      }
    +      assert(invalidColError.message == "Invalid column name: key.")
    +
    +      withSQLConf("spark.sql.caseSensitive" -> "true") {
    +        val invalidErr = intercept[AnalysisException] {
    +          sql(s"ANALYZE TABLE $table COMPUTE STATISTICS FOR COLUMNS 
${colName1.toUpperCase}")
    +        }
    +        assert(invalidErr.message == s"Invalid column name: 
${colName1.toUpperCase}.")
    +      }
    +
    +      withSQLConf("spark.sql.caseSensitive" -> "false") {
    +        val columnsToAnalyze = Seq(colName2.toUpperCase, colName1, 
colName2)
    +        val columnStats = spark.sessionState.computeColumnStats(table, 
columnsToAnalyze)
    --- End diff --
    
    Here, you can just replace it by 
    ```Scala
            val tableIdent = TableIdentifier(table, Option("default"))
            val relation = spark.sessionState.catalog.lookupRelation(tableIdent)
            val columnStats =
              AnalyzeColumnCommand(tableIdent, 
columnsToAnalyze).computeColStats(spark, relation)._2
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to