GitHub user hvanhovell opened a pull request:

    https://github.com/apache/spark/pull/15208

    [SPARK-17641][SQL] Collect_list/Collect_set should not collect null values.

    ## What changes were proposed in this pull request?
    We added native versions of `collect_set` and `collect_list` in Spark 2.0. 
These currently also (try to) collect null values, this is different from the 
original Hive implementation. This PR fixes this by adding a null check to the 
`Collect.update` method.
    
    ## How was this patch tested?
    Added a regression test to `DataFrameAggregateSuite`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hvanhovell/spark SPARK-17641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15208
    
----
commit 37c4539978f4e92fef9055dfae292b22392a0bf8
Author: Herman van Hovell <hvanhov...@databricks.com>
Date:   2016-09-23T01:45:38Z

    Do not collect null values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to