Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/15195#discussion_r80178129
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -290,8 +284,8 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
df,
dataSource.createSink(outputMode),
outputMode,
- useTempCheckpointLocation = useTempCheckpointLocation,
- recoverFromCheckpointLocation = recoverFromCheckpointLocation,
+ useTempCheckpointLocation = true,
--- End diff --
AFAIK, It is not suitable to use temporary checkpoint location for other
sinks beside "console", temporary directory will be deleted after process is
finished. So the ability of checkpoint recovery is lost.
Also for `ConsoleSink`, there's no consistency and failure recovery
guarantee, so it should not set `recoverFromCheckpointLocation` to `true`.
Correct me if I'm wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
