Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15226#discussion_r80395860
--- Diff:
core/src/main/scala/org/apache/spark/util/AsynchronousListenerBus.scala ---
@@ -117,6 +124,24 @@ private[spark] abstract class
AsynchronousListenerBus[L <: AnyRef, E](name: Stri
eventLock.release()
} else {
onDropEvent(event)
+ droppedEventsCounter.incrementAndGet()
+ }
+
+ val droppedEvents = droppedEventsCounter.get
+ if (droppedEvents > 0) {
+ // Don't log too frequently
+ if (System.currentTimeMillis() - lastReportTimestamp >= 60 * 1000) {
--- End diff --
@rxin this is not for measuring elapsed time and we also want to log it
using Date. According to the javadoc:
> This method can only be used to measure elapsed time and is not related
to any other notion of system or wall-clock time. The value returned represents
nanoseconds since some fixed but arbitrary origin time (perhaps in the future,
so values may be negative). The same origin is used by all invocations of this
method in an instance of a Java virtual machine; other virtual machine
instances are likely to use a different origin.
It's better to use `System.currentTimeMillis()` since we want to report the
timestamp in the log.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
