Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2020#discussion_r16676634
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
 ---
    @@ -173,4 +193,35 @@ object YarnSparkHadoopUtil {
         }
       }
     
    +  def lookupRack(conf: Configuration, host: String): String = {
    --- End diff --
    
    I haven't convinced myself this stuff really belongs in this class.  I can 
kind of see it Hadoop related and we don't have another Util class so I think 
its fine for now.  I do think we want to make these routines private to spark 
though since this class isn't currently private and we don't want normal users 
calling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to