Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15168#discussion_r80419919
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -420,17 +424,40 @@ case class DescribeTableCommand(table:
TableIdentifier, isExtended: Boolean, isF
val catalog = sparkSession.sessionState.catalog
if (catalog.isTemporaryTable(table)) {
+ if (partitionSpec.nonEmpty) {
+ throw new AnalysisException(
+ s"DESC PARTITION is not allowed on a temporary view:
${table.identifier}")
+ }
describeSchema(catalog.lookupRelation(table).schema, result)
} else {
val metadata = catalog.getTableMetadata(table)
describeSchema(metadata.schema, result)
- if (isExtended) {
- describeExtended(metadata, result)
- } else if (isFormatted) {
- describeFormatted(metadata, result)
+ describePartitionInfo(metadata, result)
+
+ if (partitionSpec.isEmpty) {
+ if (isExtended) {
+ describeExtendedTableInfo(metadata, result)
+ } else if (isFormatted) {
+ describeFormattedTableInfo(metadata, result)
+ describeStorageInfo(metadata, result)
+ }
} else {
- describePartitionInfo(metadata, result)
+ if (metadata.tableType == CatalogTableType.VIEW) {
+ throw new AnalysisException(
+ s"DESC PARTITION is not allowed on a view:
${table.identifier}")
+ }
+ if (DDLUtils.isDatasourceTable(metadata)) {
+ throw new AnalysisException(
+ s"DESC PARTITION is not allowed on a datasource table:
${table.identifier}")
+ }
+ val partition = catalog.getPartition(table, partitionSpec)
+ if (isExtended) {
+ describeExtendedDetailPartitionInfo(table, metadata, partition,
result)
+ } else if (isFormatted) {
+ describeFormattedDetailPartitionInfo(table, metadata, partition,
result)
+ describeStorageInfo(metadata, result)
+ }
--- End diff --
Yep. I'll refactor them into another function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
