Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/14818 @felixcheung If I added it to `spark.glm`, it will break the current `spark.glm` interface. `setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), function(data, formula, family = gaussian, tol = 1e-6, maxIter = 25, weightCol = NULL, regParam = 0.0) ` With this interface, I can't add `LogisticRegressionModel`. I think it is better to add it to a separate Class, instead of the `GeneralizedLinearRegressionModel`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org