Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11119#discussion_r80565861
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -107,24 +133,34 @@ trait DefaultReadWriteTest extends TempDirectory {
self: Suite =>
}
val model = estimator.fit(dataset)
- // Test Estimator save/load
- val estimator2 = testDefaultReadWrite(estimator)
- testParams.foreach { case (p, v) =>
- val param = estimator.getParam(p)
- assert(estimator.get(param).get === estimator2.get(param).get)
+ val testFunctions = if (testParams.contains("initialModel")) {
+ Map(("initialModel", checkModelData.asInstanceOf[(Any, Any) =>
Unit]))
--- End diff --
On second thought, it really might actually be easiest to override the
equals method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
