Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/15053
  
    IMHO, i think the original author intended to avoid creating each dataframe 
in each method docstring. I am uncertain about doing each method docstring 
although I do prefer verbose/complete documentation. If we should go for the 
Suggestion A, then I think we chould
    
    - verify if there is any degradation from this cahnge. (e.g. test time 
increase) and then decide if this change is worth it. I mean we should be able 
to defence with a concreate reason or reference not only now here but also in 
the future. 
    
    -  find another way to reach this goal.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to