Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15252
cc @hvanhovell for review. This is mostly simple copy/paste. I did look
over the warnings in IntelliJ and spacing issues.
Also @yhuai and @hvanhovell - I noticed there was virtually 0 unit test
coverage for this complicated feature. There are some end-to-end tests, but we
should have built unit tests to cover the fundamental classes (e.g.
BoundOrdering, RowBuffer, WindowFunctionFrame). We need to be more careful in
creating new code & reviewing code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
