Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/15247#discussion_r80804419
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -279,7 +279,8 @@ private[history] class ApplicationCache(
time(metrics.loadTimer) {
operations.getAppUI(appId, attemptId) match {
case Some(LoadedAppUI(ui, updateState)) =>
- val completed =
ui.getApplicationInfoList.exists(_.attempts.last.completed)
+ val completed = ui.getApplicationInfo(appId)
+ .map(_.attempts.last.completed).getOrElse(false)
--- End diff --
Though I get what you're trying to do here, I'm not sure this is actually
faster in this case since the list is only length one. It may be cleaner to
leave this as is, what are other reviewers opinions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
