Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15250#discussion_r80821155
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -290,7 +290,12 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
.filter { entry =>
try {
val prevFileSize =
fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
- !entry.isDirectory() && prevFileSize < entry.getLen()
+ !entry.isDirectory() &&
+ // FsHistoryProvider generates a hidden file which can't be
read, and the user may
--- End diff --
Minor, but I'd avoid mentioning user-created files here. Because users can
create non-hidden files too. The mod time tracking code should take care of not
parsing those files multiple times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
