Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15239#discussion_r80841143
  
    --- Diff: R/pkg/R/utils.R ---
    @@ -334,6 +334,27 @@ varargsToEnv <- function(...) {
       env
     }
     
    +# Utility function to capture the varargs into environment object but all 
values are converted
    +# into string.
    +varargsToStrEnv <- function(...) {
    +  pairs <- list(...)
    +  env <- new.env()
    +  for (name in names(pairs)) {
    +    value <- pairs[[name]]
    +    if (!(is.logical(value) || is.numeric(value) || is.character(value) || 
is.null(value))) {
    +      stop("value[", value, "] in key[", name, "] is not convertable to 
string.")
    --- End diff --
    
    I think "... logical, character, numeric and NULL" as these are the R names.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to